expires_in appears to be a string when returned from the token server

When we reach this line of code, we get "TypeError: unsupported type for timedelta seconds component: str"

google-auth-library-python/google/oauth2/_client.py

Line 123 in 6c1297c

return _helpers.utcnow() + datetime.timedelta(seconds=expires_in)

It would appear that the response from the token server has expires_in as a string:

Request:

https://securetoken.googleapis.com/v1/token?key=AI... 
{
  'grant_type': 
  'refresh_token', 
  'client_id': '76...', 
  'client_secret': '...', 
  'refresh_token': 'AO...'
}

Response:

{
  'access_token': 'ey...', 
  **'expires_in': '3600'**, 
  'token_type': 'Bearer', 
  'refresh_token': 'AO...', 
  'id_token': 'ey...', 
  'user_id': 'Xs...', 
  'project_id': '23...'
}

Seems this code should expect a string and not an integer.

@rfloydb

Thanks for the report @rfloydb ! We will investigate and report back

@rfloydb

Hi @rfloydb can you provide some more details on what you are trying to accomplish? And perhaps some details about this workflow?

I am trying to refresh a token. Roughly this:

import firebase_admin

from firebase_admin import auth
from google.auth.transport.requests import Request
from google.oauth2.credentials import Credentials

firebase_admin.initialize_app()

(id_token, refresh_token) = tokens()
(client_id, client_secret) = client_id_and_secret()
creds = Credentials(
    id_token, 
    refresh_token, 
    client_id = client_id,
    client_secret = client_secret,
    token_uri = 'https://securetoken.googleapis.com/v1/token?key=AI...',
)

try:
    decoded_token = auth.verify_id_token(creds.id_token)
except firebase_admin.auth.ExpiredIdTokenError:
    try:
        r = Request()
        creds.refresh(r)

fix: Make OAUTH2.0 client resistant to string type 'expires_in' respo…

@rfloydb

@rfloydb This will be fixed in the next release. That should happen either today or early next week.

fix: Make OAUTH2.0 client resistant to string type 'expires_in' respo…

Navigation Menu

Repository navigation

expires_in appears to be a string when returned from the token server #1207

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

expires_in appears to be a string when returned from the token server #1207

Description

Activity

clundin25 commented on Jan 3, 2023

clundin25 commented on Jan 4, 2023

rfloydb commented on Jan 4, 2023

clundin25 commented on Jan 6, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions