Repository navigation
Change lastBytePos to long in MediaHttpDownloader.setContentRange - #985
Merged
Merged
Conversation
|
As if this functions receives an int, assigning it to long would still have int data. By definition, in java int can hold maximum of 2^31 - 1 It should rather be "... Eg: bytes=lastBytePos-firstBytePos." |
45Jayjay1969
approved these changes
Dec 6, 2016
|
Any reason this hasn't been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #937.
This PR breaks
clirrcheck with the following error:I don't see any major issue with this as
MediaHttpDownloader.lastBytePosfield is already along, but correct me if I'm wrong.