Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: fix docs build#1488

Merged
parthea merged 5 commits into
mainfrom
parthea-patch-3
Nov 11, 2022
Merged

chore: fix docs build#1488
parthea merged 5 commits into
mainfrom
parthea-patch-3

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Nov 11, 2022

This PR removes the undoc-members option of sphinx to address the error duplicate object description seen in the docs build for downstream clients. See build log here

See the definition for undoc-members here:

:undoc-members: (no value)
If set, autodoc will also generate document for the members not having docstrings:

https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html#directive-option-automodule-undoc-members

This addresses the error "duplicate object description" seen in the docs build of downstream clients.
@parthea parthea requested review from a team November 11, 2022 13:17
@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Nov 11, 2022
Copy link
Copy Markdown
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a problem for autogenerated clients. For handwritten libraries the maintainers have choice to add this themselves, so LGTM.

@parthea parthea merged commit 23d20c1 into main Nov 11, 2022
@parthea parthea deleted the parthea-patch-3 branch November 11, 2022 21:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants