Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

ci: run goldens through mypy#1096

Closed
busunkim96 wants to merge 3 commits into
masterfrom
goldens-mypy
Closed

ci: run goldens through mypy#1096
busunkim96 wants to merge 3 commits into
masterfrom
goldens-mypy

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 commented Nov 23, 2021

For #1092.

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
Copy link
Copy Markdown
Contributor

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say from a CI perspective, just move the mypy check into the integration task.

@parthea
Copy link
Copy Markdown
Contributor

parthea commented Jan 26, 2022

I'm going to merge this PR with #1132

@parthea parthea closed this Jan 26, 2022
@busunkim96 busunkim96 deleted the goldens-mypy branch April 7, 2022 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants