Conversation
Contributor
Author
|
@JoannaBako could you try these 2x tests against some physical devices? I do not have a device to hand with NTPv4 or one that uses a DHCP provided NTP server. |
jhughesoti
reviewed
Jul 7, 2023
jhughesoti
left a comment
jhughesoti
left a comment
Contributor
There was a problem hiding this comment.
Tested with a device that supports NTPv4 and option 42 and got passing results as expected. Don't have a way to confirm failing results though.
Contributor
Author
|
@jhughesbiot Could you take a look at the pylint of the current dev branch? Not sure what's happened, seems the pylint score has increased on the dhcp branch maybe but it already merged. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 2x NTP tests: