Repository navigation
Support variant_deps and defines in CMake generation. - #1302
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
generate_cmake.go previously ignored variant_deps on create_tcmalloc_libraries and create_tcmalloc_testsuite rules (such as mock_static_forwarder and central_freelist_test) and only handled local_defines, ignoring defines. Parse variant_deps and defines in generateCMake, emit VARIANT_DEPS on variant rules, and expand VARIANT_DEPS per build and test variant in tcmalloc_variants.cmake. PiperOrigin-RevId: 994040838
copybara-service
Bot
force-pushed
the
test_994040838
branch
from
October 6, 2026 01:56
0026026 to
dfb9197
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support variant_deps and defines in CMake generation.
generate_cmake.go previously ignored variant_deps on create_tcmalloc_libraries and create_tcmalloc_testsuite rules (such as mock_static_forwarder and central_freelist_test) and only handled local_defines, ignoring defines.
Parse variant_deps and defines in generateCMake, emit VARIANT_DEPS on variant rules, and expand VARIANT_DEPS per build and test variant in tcmalloc_variants.cmake.