Repository navigation
Fix absl/algorithm:container target mapping and deduplicate multi-target deps. - #1301
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…get deps. mapTargetName previously matched parts[1] == "container" for @com_google_absl//absl/algorithm:container, emitting absl::flat_hash_map, absl::flat_hash_set, and absl::inlined_vector instead of absl::algorithm_container. Returning multi-target mappings as a single pre-joined string with embedded newlines and quotes also bypassed sorting and deduplication in formatList, leaving duplicate absl::flat_hash_map entries in generated CMakeLists.txt files. Map @com_google_absl//absl/algorithm:container to absl::algorithm_container, map @com_google_googletest//:gtest and :gtest_main directly to GTest::gmock and GTest::gmock_main (which link GTest::gtest transitively), and deduplicate sorted target entries in formatList with slices.Compact. PiperOrigin-RevId: 994040843
copybara-service
Bot
force-pushed
the
test_994040843
branch
from
October 9, 2026 05:40
aec176d to
62ac85c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix absl/algorithm:container target mapping and deduplicate multi-target deps.
mapTargetName previously matched parts[1] == "container" for @com_google_absl//absl/algorithm:container, emitting absl::flat_hash_map, absl::flat_hash_set, and absl::inlined_vector instead of absl::algorithm_container. Returning multi-target mappings as a single pre-joined string with embedded newlines and quotes also bypassed sorting and deduplication in formatList, leaving duplicate absl::flat_hash_map entries in generated CMakeLists.txt files.
Map @com_google_absl//absl/algorithm:container to absl::algorithm_container, map @com_google_googletest//:gtest and :gtest_main directly to GTest::gmock and GTest::gmock_main (which link GTest::gtest transitively), and deduplicate sorted target entries in formatList with slices.Compact.