Repository navigation
Link ALWAYSLINK CMake libraries via WHOLE_ARCHIVE interface targets. - #1297
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
In CMake, target_link_libraries between OBJECT libraries does not propagate transitive object files ($<TARGET_OBJECTS:...>) to executables, causing non-variant cc_test and cc_binary targets to fail at link time with undefined references. Additionally, $<LINK_LIBRARY:WHOLE_ARCHIVE,...> is ignored by CMake on OBJECT libraries.
Build tcmalloc_cc_library targets with SRCS as STATIC libraries and expose ALWAYSLINK targets via an INTERFACE library wrapping $<LINK_LIBRARY:WHOLE_ARCHIVE,${TCMALLOC_NAME}>.
PiperOrigin-RevId: 994040839
copybara-service
Bot
force-pushed
the
test_994040839
branch
from
October 9, 2026 05:23
cc9f9a5 to
8e290f4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link ALWAYSLINK CMake libraries via WHOLE_ARCHIVE interface targets.
In CMake, target_link_libraries between OBJECT libraries does not propagate transitive object files ($<TARGET_OBJECTS:...>) to executables, causing non-variant cc_test and cc_binary targets to fail at link time with undefined references. Additionally, $ <LINK_LIBRARY:WHOLE_ARCHIVE,...> is ignored by CMake on OBJECT libraries.
Build tcmalloc_cc_library targets with SRCS as STATIC libraries and expose ALWAYSLINK targets via an INTERFACE library wrapping$<LINK_LIBRARY:WHOLE_ARCHIVE,$ {TCMALLOC_NAME}>.