Repository navigation
Propagate per-CPU cache size updates in CpuCache::SetCacheLimit. - #1283
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When CpuCache::SetCacheLimit or TCMalloc_Internal_SetMaxPerCpuCacheSize is called after per-CPU caches are activated, update each CPU's capacity and available bytes under resize_lock_ and resize_[cpu].lock, draining populated cores via DrainLocksHeld when the new limit shrinks below unallocated slack. Hold resize_[cpu].lock across the available-byte exchange and restore in ResizeCpuSizeClasses so available bytes are never hidden in a local variable while resize_[cpu].lock is held, and increment capacity before available in StealFromOtherCache so available <= capacity always holds. Check subtle::percpu::IsFastNoInit() in UseBackingShardedTransferCache so draining a core from a thread without rseq registered falls back to the unsharded transfer cache. PiperOrigin-RevId: 993486849
copybara-service
Bot
force-pushed
the
test_993486849
branch
from
October 5, 2026 17:47
7585f06 to
b483eb1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate per-CPU cache size updates in CpuCache::SetCacheLimit.
When CpuCache::SetCacheLimit or TCMalloc_Internal_SetMaxPerCpuCacheSize is
called after per-CPU caches are activated, update each CPU's capacity and
available bytes under resize_lock_ and resize_[cpu].lock, draining populated
cores via DrainLocksHeld when the new limit shrinks below unallocated slack.
Hold resize_[cpu].lock across the available-byte exchange and restore in
ResizeCpuSizeClasses so available bytes are never hidden in a local variable
while resize_[cpu].lock is held, and increment capacity before available in
StealFromOtherCache so available <= capacity always holds. Check
subtle::percpu::IsFastNoInit() in UseBackingShardedTransferCache so draining a
core from a thread without rseq registered falls back to the unsharded transfer
cache.