unicode() --> six.u() for Python 3 compatibility

[cclauss]

unicode() was removed from Python 3 because all strs are unicode.

Executing these lines in Python 3 would raise a NameError.

• https://pythonhosted.org/six/#six.u

[dbieber]

lgtm!, thanks

[djizm]

What is 120:60:130:LG simplink up skaleing hdmi---------4/4/4/3/4/4...0hms speakers ---------- Forwarded message ---------- From: "cclauss" <notifications@github.com> Date: Jan 10, 2018 7:06 PM Subject: [google/python-fire] unicode() --> six.u() for Python 3 compatibility (#111) To: "google/python-fire" <python-fire@noreply.github.com> Cc: "Subscribed" <subscribed@noreply.github.com> *unicode()* was removed from Python 3 because all strs are unicode. Executing these lines in Python 3 would raise a NameError. - https://pythonhosted.org/six/#six.u

…

------------------------------ You can view, comment on, or merge this pull request online at: #111 Commit Summary - unicode() --> six.u() for Python 3 compatibility File Changes - *M* fire/parser_fuzz_test.py <https://github.com/google/python-fire/pull/111/files#diff-0> (4) Patch Links: - https://github.com/google/python-fire/pull/111.patch - https://github.com/google/python-fire/pull/111.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#111>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZJFGwy5S5dCOd9Jl3S_34B51V55hv0kks5tJVCBgaJpZM4RaIWH> .

[dbieber]

Turns out six.u does not behave the same as unicode in Python 2. six.u expects a string literal as input, whereas unicode can accept other types like bool and converts them to unicode.
So when value is a bool, six.u errors.

[cclauss]

six.text_type() seems like a better substitute.

[dbieber]

Yeah, that looks right. Thanks.