Skip to content

fix(frontend): navbar search breaking after Turbo navigation#4561

Merged
another-rex merged 1 commit into
google:masterfrom
ashmod:fix/turbo-cache-listeners
Jan 2, 2026
Merged

fix(frontend): navbar search breaking after Turbo navigation#4561
another-rex merged 1 commit into
google:masterfrom
ashmod:fix/turbo-cache-listeners

Conversation

@ashmod
Copy link
Copy Markdown
Contributor

@ashmod ashmod commented Jan 1, 2026

There's a search-bar bug on the website where Turbo’s back/forward cache doesn’t keep the search button’s event wiring, so after returning to a cached page the search icon becomes unresponsive. This can be reproduced by:

  1. Visit the blog page
  2. Go to any blog post, then press the browser's back button
  3. Try clicking the search icon - it won't work (since the blog page is cached by Turbo)

This change ensures the search wiring is torn down before caching and cleanly re‑applied on restore, so the search stays functional after Turbo navigation.

@another-rex
Copy link
Copy Markdown
Contributor

/gcbrun

Copy link
Copy Markdown
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@another-rex another-rex merged commit 1416182 into google:master Jan 2, 2026
20 checks passed
another-rex pushed a commit that referenced this pull request Apr 22, 2026
The theme toggle button stopped working on Turbo-cached pages. This
follows the same pattern as #4561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants