Make VKeyProcessor an isolating processor - #3240
Merged
Merged
Conversation
Register VKeyProcessor as an ISOLATING incremental annotation processor in META-INF/gradle/incremental.annotation.processors and pass the annotated TypeElement as the originating element when generating VKeyConverter classes via JavaPoet. Previously, because VKeyProcessor was not declared incremental, Gradle disabled incremental Java compilation for both :core:compileJava and :core:compileTestJava, forcing a full recompilation of all ~3,000 source and generated classes in :core on every edit. This is because without knowing that the processor's input is isolated to a single test class, Gradle had to recompile everything. This cuts recompilation time (after you make, say, a one-line change) from like 20-30 seconds to like 3-5 seconds
gbrodman
force-pushed
the
vkey-processor-incremental
branch
from
September 28, 2026 20:57
3674bd1 to
cec6be0
Compare
weiminyu
approved these changes
Sep 29, 2026
weiminyu
left a comment
weiminyu
left a comment
Collaborator
There was a problem hiding this comment.
@weiminyu reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register VKeyProcessor as an ISOLATING incremental annotation processor in META-INF/gradle/incremental.annotation.processors and pass the annotated TypeElement as the originating element when generating VKeyConverter classes via JavaPoet.
Previously, because VKeyProcessor was not declared incremental, Gradle disabled incremental Java compilation for both :core:compileJava and :core:compileTestJava, forcing a full recompilation of all ~3,000 source and generated classes in :core on every edit. This is because without knowing that the processor's input is isolated to a single test class, Gradle had to recompile everything.
This cuts recompilation time (after you make, say, a one-line change) from like 20-30 seconds to like 3-5 seconds
This change is