Allow test TLDs in drop list export for non-production environments - #3231
Merged
Merged
Conversation
CydeWeys
enabled auto-merge
September 15, 2026 19:32
gbrodman
approved these changes
Sep 15, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
CydeWeys
force-pushed
the
update-drop-list-xap-filter
branch
from
October 1, 2026 16:03
e1c40e3 to
4729d8a
Compare
In non-production environments (e.g. sandbox), allow TEST TLDs to be included in the domain drop list export so XAP can be verified with test TLDs. Also remove the isInvoicingEnabled filter globally, as the tld.getExpiryAccessPeriodModeAt(now) check is sufficient. TAG=agy CONV=67020217-639f-40a2-9d7c-54e592c91a53
CydeWeys
force-pushed
the
update-drop-list-xap-filter
branch
from
October 1, 2026 17:59
4729d8a to
1288141
Compare
gbrodman
approved these changes
Oct 1, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 2 files and all commit messages.
Reviewable status:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In non-production environments (e.g. sandbox), allow TEST TLDs to be included in the domain drop list export so XAP can be verified with test TLDs.
Also remove the isInvoicingEnabled filter globally, as the tld.getExpiryAccessPeriodModeAt(now) check is sufficient.
TAG=agy
CONV=67020217-639f-40a2-9d7c-54e592c91a53
This change is