Add an aggregate module for DNS writers#2769
Merged
Merged
Conversation
Add a new DnsWritersModule for use by the component classes. To override the set of writers installed, we can easily overwrite this file with a private version.
weiminyu
force-pushed
the
dns-writers-module
branch
from
June 6, 2025 19:25
ecf0824 to
bad3f82
Compare
gbrodman
approved these changes
Jun 9, 2025
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @CydeWeys)
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
Add a new DnsWritersModule for use by the component classes. To override the set of writers installed, we can easily overwrite this file with a private version.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
Add a new DnsWritersModule for use by the component classes. To override the set of writers installed, we can easily overwrite this file with a private version.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
Add a new DnsWritersModule for use by the component classes. To override the set of writers installed, we can easily overwrite this file with a private version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new DnsWritersModule for use by the component classes.
To override the set of writers installed, we can easily overwrite this file with a private version.
Tested in crash both the server and the tool.
This change is