Repository navigation
Merged
Conversation
'reviewed' event objects returned by the Timeline Events API have a 'state' property that tells you the state of a submitted review. This commit adds the code to parse this property.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
Author
|
Merging this PR would fix issue #1885. |
gmlewis
approved these changes
Jun 8, 2021
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @campesel !
LGTM.
Awaiting second LGTM before merging.
Author
|
@gmlewis Thanks for the approval! |
Author
|
@wesleimp Looks good to you? |
Collaborator
|
Friendly ping @wesleimp |
gmlewis
pushed a commit
that referenced
this pull request
Jul 8, 2021
This was referenced Mar 28, 2026
jlaportebot
added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
jlaportebot
added a commit
to jlaportebot/go-github
that referenced
this pull request
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Timeline Events API can return a
reviewedevent object when listing events for a pull request. One of the properties of this object isstate, which tells you the state of a submitted review.The values
statecan have are:commentedchanges_requestedapprovedThis PR adds this field to the
Timelinestruct defined inissues_timeline.goto make it possible to tell the state of a review when listing pull request events.