Repository navigation
Report BadShiftAmount for constant shift amounts - #6324
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
BadShiftAmount only inspected LiteralTree right operands, so a shift by a compile-time constant variable, such as a private static final int BITS = 32, was not reported even though javac folds it to the same out-of-range amount Use ASTHelpers.constValue so named constants are covered, and derive the suggested fix from the same constant value instead of casting to LiteralTree
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6304
BadShiftAmount only inspected
LiteralTreeright operands, so a shift by a compile-time constant variable such asprivate static final int BITS = 32was not reported even though javac folds it to the same out-of-range amountUse
ASTHelpers.constValueso named constants are covered, and derive the suggested fix from the same constant value instead of casting the right operand toLiteralTreeThe
TOO_LARGEcase in the test also verifies the replacement fix path for named constants