Repository navigation
CheckReturnValue: avoid unnecessary work during rule evaluation - #6314
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
* Evaluate ResultUsePolicyEvaluator rules with loops rather than nested stream pipelines. Rules are evaluated in the same order and evaluation stops at the first rule that returns a policy, as before. * In the AutoValue rules, check whether each supertype in the closure of the method's owner has the relevant annotation before searching that supertype for a supermethod, and use ClassName to cache the binary annotation name. * Don't use a stream to find CRV-relevant annotations on each method and class. On Chromium's chrome_java target (median of 5 interleaved runs, idle machine), time spent in CheckReturnValue drops from 459ms (453ms after Round 1) to 292ms (-36%). PiperOrigin-RevId: 1013480905
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckReturnValue: avoid unnecessary work during rule evaluation
stream pipelines. Rules are evaluated in the same order and evaluation
stops at the first rule that returns a policy, as before.
the method's owner has the relevant annotation before searching that
supertype for a supermethod, and use ClassName to cache the binary
annotation name.
class.
On Chromium's chrome_java target (median of 5 interleaved runs, idle machine), time spent in CheckReturnValue drops from 459ms (453ms after Round 1) to 292ms (-36%).