Repository navigation
Recognize compile-time TimeUnit conversion constants - #6286
Open
wozhenbang2004 wants to merge 2 commits into
Open
wozhenbang2004 wants to merge 2 commits into
wozhenbang2004 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6279.
Use javac's compile-time constant value rather than parsing the source text, so integral expressions, named constants, and literals with separators or radix prefixes follow the existing conversion checks. This also avoids an incorrect suggested result for octal literals.
Only treat a receiver as a known unit when its symbol is a
TimeUnitenum constant. For an enum constant accessed through an expression, report the conversion without replacing the whole call, preserving the receiver's evaluation and possible side effects. The tests cover constant and nonconstant arguments, suggested fixes, shadowing variables, and expression-qualified receivers.Validation:
git diff --checkpassed.