Skip to content

Optimize google::api::expr::Unparse by removing unnecessary map copying. #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Dec 3, 2025
Merged

Optimize google::api::expr::Unparse by removing unnecessary map copying. #1798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions common/operators.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ const absl::string_view CelOperator::OPT_INDEX = "_[?_]";
const absl::string_view CelOperator::OPT_SELECT = "_?._";

int LookupPrecedence(const std::string& op) {
auto precs = Precedences();
const auto& precs = Precedences();
auto p = precs.find(op);
if (p != precs.end()) {
return p->second;
Expand All @@ -175,7 +175,7 @@ int LookupPrecedence(const std::string& op) {
}

absl::optional<std::string> LookupUnaryOperator(const std::string& op) {
auto unary_ops = UnaryOperators();
const auto& unary_ops = UnaryOperators();
auto o = unary_ops.find(op);
if (o == unary_ops.end()) {
return absl::optional<std::string>();
Expand All @@ -184,7 +184,7 @@ absl::optional<std::string> LookupUnaryOperator(const std::string& op) {
}

absl::optional<std::string> LookupBinaryOperator(const std::string& op) {
auto bin_ops = BinaryOperators();
const auto& bin_ops = BinaryOperators();
auto o = bin_ops.find(op);
if (o == bin_ops.end()) {
return absl::optional<std::string>();
Expand All @@ -193,7 +193,7 @@ absl::optional<std::string> LookupBinaryOperator(const std::string& op) {
}

absl::optional<std::string> LookupOperator(const std::string& op) {
auto ops = Operators();
const auto& ops = Operators();
auto o = ops.find(op);
if (o == ops.end()) {
return absl::optional<std::string>();
Expand All @@ -202,7 +202,7 @@ absl::optional<std::string> LookupOperator(const std::string& op) {
}

absl::optional<std::string> ReverseLookupOperator(const std::string& op) {
auto rev_ops = ReverseOperators();
const auto& rev_ops = ReverseOperators();
auto o = rev_ops.find(op);
if (o == rev_ops.end()) {
return absl::optional<std::string>();
Expand Down