Checking dict keys fails #58

Activity

1. ncw commented on May 18, 2019

   

   ncw

   on May 18, 2019

   Collaborator

   More actions

   Implementing __iter__ for dict is very useful.

   However for in to be efficient we should be implementing __contains__

   gpython/py/sequence.go

   Lines 121 to 147 in 61059b4

   	// SequenceContains returns True if obj is in seq
   	func SequenceContains(seq, obj Object) (found bool, err error) {
   	if I, ok := seq.(I__contains__); ok {
   	result, err := I.M__contains__(obj)
   	if err != nil {
   	return false, err
   	}
   	return result == True, nil
   	} else if result, ok, err := TypeCall1(seq, "__contains__", obj); ok {
   	if err != nil {
   	return false, err
   	}
   	return result == True, nil
   	}
   	var loopErr error
   	err = Iterate(seq, func(item Object) bool {
   	var eq Object
   	eq, loopErr = Eq(item, obj)
   	if loopErr != nil {
   	return true
   	}
   	if eq == True {
   	found = true
   	return true
   	}
   	return false
   	})
2. drew-512 commented on Feb 16, 2022

   

   drew-512

   on Feb 16, 2022

   Contributor

   More actions

   suggest @sbinet close -- addressed in #65
3. sbinet commented on Feb 22, 2022

   

   sbinet

   on Feb 22, 2022

   Member

   More actions

   fixed w/ #65 .
4. sbinet

   closed this as completedon Feb 22, 2022