Skip to content

Errors are suppressed in generator comprehensions #32

Closed
Closed
Errors are suppressed in generator comprehensions#32
Assignees
corona10
Labels
bugSomething isn't working

Description

@ncw
ncw
opened on Oct 10, 2018
>>> list(i for x in range(10))
[]

Which should have output

>>> list(i for x in range(10))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "<stdin>", line 1, in <genexpr>
NameError: name 'i' is not defined

Activity

  1. ncw
    added
    bugSomething isn't working
    on Oct 10, 2018

  2. corona10 commented on Nov 24, 2018

    @corona10
    corona10
    on Nov 24, 2018
    Collaborator

    @ncw I will take a look this issue

  3. corona10
    self-assigned this
    on Nov 24, 2018

  4. corona10 commented on Nov 24, 2018

    @corona10
    corona10
    on Nov 24, 2018
    Collaborator
    list(i for x in range(10))
-> Expression(body=Call(func=Name(id='list', ctx=Load()), args=[GeneratorExp(elt=Name(id='i', ctx=Load()), generators=[comprehension(target=Name(id='x', ctx=Store()), iter=Call(func=Name(id='range', ctx=Load()), args=[Num(n=10)], keywords=[], starargs=None, kwargs=None), ifs=[])])], keywords=[], starargs=None, kwargs=None))

    [i for x in range(10)]
-> Expression(body=ListComp(elt=Name(id='i', ctx=Load()), generators=[comprehension(target=Name(id='x', ctx=Store()), iter=Call(func=Name(id='range', ctx=Load()), args=[Num(n=10)], keywords=[], starargs=None, kwargs=None), ifs=[])]))

  5. ncw commented on Nov 27, 2018

    @ncw
    ncw
    on Nov 27, 2018
    CollaboratorAuthor

    @corona10 are you getting anywhere with this? Do you need help?

  6. corona10 commented on Nov 28, 2018

    @corona10
    corona10
    on Nov 28, 2018
    Collaborator

    @ncw

    gpython/py/generator.go

    Line 100 in 2609237

    res, err := VmRunFrame(it.Frame)

    Well, I tracked the code and I found that something issue in this side.
    But I don't know which is the main reason for this issue yet.

    So if you already solve this issue, Then please upload a PR for this issue :)
    I can learn something from your PR.

  7. ncw commented on Nov 28, 2018

    @ncw
    ncw
    on Nov 28, 2018
    CollaboratorAuthor

    Well, I tracked the code and I found that something issue in this side.
    But I don't know which is the main reason for this issue yet.

    I haven't figured it out either!

    But yes, it is probably something to do with making a new Vm Frame and the errors being suppressed there rather than propagated.

  8. corona10 commented on Nov 28, 2018

    @corona10
    corona10
    on Nov 28, 2018
    Collaborator

    @ncw
    I found the main reason for this bug.
    I will upload the PR soon

  9. ncw commented on Nov 28, 2018

    @ncw
    ncw
    on Nov 28, 2018
    CollaboratorAuthor

    I found the main reason for this bug.
    I will upload the PR soon

    Great. Don't forget a failing test case :-)

  10. ncw
    closed this as completedin #38on Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions