Open
Conversation
Open
Member
|
I upgraded React/ReactNative in #883. Would you mind refactoring old react lifecycle functions again? Or we can record files as a new issue and refactor one by one. |
Contributor
Author
|
@chinesedfan Please create a new issue with a list of files need to be updated. I will try to work on those as much as possible. Thanks. |
6 tasks
Member
|
@Arjun-sna See #887. You have did most of them I think. |
refactor old lifecycle callbacks with new ones
Arjun-sna
force-pushed
the
upgrade_react
branch
from
d13a9e8 to
8a733fe
Compare
Contributor
Author
|
@chinesedfan Sorry for the delayed update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Upgrade react version to 16.6.0
Refactored old react lifecycle functions with new functions