refactor(ui): update language selectionscreen #703
Merged
Conversation
move language settings to a new page 620
update contributors
Arjun-sna
changed the title
update title when user selects a language
machour
requested changes
Jan 26, 2018
Member
machour
left a comment
machour
left a comment
There was a problem hiding this comment.
Thank you @Arjun-sna, this is beautiful! 🎉
Some cosmetics:
- Could you set the background color of the new screen to white ?
- Can you make the list item a little bigger in height (same height as the item with the checkbox mark, so that there are no differences)
Let us know if you need any help!
set color and height of language list item consistent with rest of the app
ocarreterom
reviewed
Jan 27, 2018
Contributor
ocarreterom
left a comment
ocarreterom
left a comment
There was a problem hiding this comment.
Some questions... :)
| {emojifyText(item.emojiCode)} | ||
| </Text> | ||
| <Text style={styles.listTitle}>{item.name}</Text> | ||
| </View> |
| <ViewContainer> | ||
| <FlatList | ||
| data={languages} | ||
| renderItem={({ item }) => { |
Contributor
There was a problem hiding this comment.
Go to an independent function?
Member
|
@Arjun-sna I just merged #702 which migrated the user options screen to styled component. Could you follow @ocarreterom sound advice and migrate |
machour
approved these changes
Jan 27, 2018
Member
|
Wonderfull work, thank you @Arjun-sna ! |
housseindjirdeh
approved these changes
Jan 28, 2018
Member
housseindjirdeh
left a comment
housseindjirdeh
left a comment
There was a problem hiding this comment.
This is so great @Arjun-sna, thank you and WELCOME <3
| }, | ||
| { | ||
| "login": "Arjun-sna", | ||
| "name": "Arjun", |
Member
|
And thanks a million for reviewing @machour @ocarreterom 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshots
Description
Added a new screen for updating user language settings