fix(locale): Check before configuring locale#476
Conversation
|
@chinesedfan thanks for the fix, but I'm already preparing PR with fixing this bug. In your PR, Chinese language will never be used, because its locale needs to be changed separately, therefore it is only the elimination of the error, but nevertheless the problem with the fact that the language does not apply will not be fixed, it will not be Chinese language, but English. It took me more time to fix, because I'm still doing the refactoring of the current localization, tomorrow I will send PR. |
|
@lex111 In fact, I am a little confused about the relationship between GitPoint locale and moment locale. If GitPoint doesn't support Chinese, why should we set moment locale as Chinese? |
|
@chinesedfan you are right, I will consider this. |
|
Thanks a million for this @chinesedfan, was this or something similar addressed in your PR @lex111? |
|
@housseindjirdeh Ha, this thing has been fixed in #479. |
Fixes #436.
If the provided locale is not supported by
moment, just useen.