Skip to content

fix(locale): Check before configuring locale#476

Closed
chinesedfan wants to merge 1 commit into
gitpoint:masterfrom
chinesedfan:fixlocale
Closed

fix(locale): Check before configuring locale#476
chinesedfan wants to merge 1 commit into
gitpoint:masterfrom
chinesedfan:fixlocale

Conversation

@chinesedfan
Copy link
Copy Markdown
Member

Fixes #436.

If the provided locale is not supported by moment, just use en.

@lex111
Copy link
Copy Markdown
Member

lex111 commented Oct 14, 2017

@chinesedfan thanks for the fix, but I'm already preparing PR with fixing this bug.

In your PR, Chinese language will never be used, because its locale needs to be changed separately, therefore it is only the elimination of the error, but nevertheless the problem with the fact that the language does not apply will not be fixed, it will not be Chinese language, but English. It took me more time to fix, because I'm still doing the refactoring of the current localization, tomorrow I will send PR.

@chinesedfan
Copy link
Copy Markdown
Member Author

@lex111 In fact, I am a little confused about the relationship between GitPoint locale and moment locale. If GitPoint doesn't support Chinese, why should we set moment locale as Chinese?

@lex111
Copy link
Copy Markdown
Member

lex111 commented Oct 15, 2017

@chinesedfan you are right, I will consider this.

@housseindjirdeh
Copy link
Copy Markdown
Member

Thanks a million for this @chinesedfan, was this or something similar addressed in your PR @lex111?

@chinesedfan
Copy link
Copy Markdown
Member Author

@housseindjirdeh Ha, this thing has been fixed in #479.

@chinesedfan chinesedfan deleted the fixlocale branch October 16, 2017 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants