fix(issue): Consolidate issue link parsing#463
Merged
Conversation
Member
|
Nice catch buddy, but I think you're fixing another unknown bug here. #462 is a bug happening when reading an issue. There's no navigation problem related there, but an Animated related exception (see my comments on that issue). If I dismiss the red screen, I do see the issue screen along with some of its comments. The bug there is supposedly with a TouchOpacity element. Still haven't investigate it yet. |
Member
machour
approved these changes
Oct 10, 2017
lex111
approved these changes
Oct 10, 2017
Member
Author
housseindjirdeh
approved these changes
Oct 11, 2017
Member
housseindjirdeh
left a comment
There was a problem hiding this comment.
Thanks a million for this @chinesedfan, and good catch :O :O
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FixesDiscovered in #462.The regular expression can't match anything if
issueURLis a issue comment, likehttps://github.com/octokit/discussions/issues/7#issuecomment-327616339. It causes[1]throws an error.