Repository navigation
feat: select text in web pages through WebKit text markers - #88
Merged
Merged
Conversation
iamnbutler
force-pushed
the
feat/web-select
branch
from
October 17, 2026 07:05
aa1c947 to
36bca42
Compare
This was referenced Oct 17, 2026
Merged
Closed
iamnbutler
added a commit
that referenced
this pull request
Oct 20, 2026
#188) (#189) * native2: selecting web text focuses the page, so Edit > Copy copies it (#188) Why: native2/Sources/DesktopMac/WebText.swift | Safari focuses its address field when it opens a page in the background, so Copy after a marker selection copied the URL; focus the web area before selecting, since focusing can move the selection Why: scripts/live-check.mjs | Safari disables Copy and has no in-window keyboard focus while inactive, so the #88 copy runs Edit > Copy after desktop_activate; background Command-C and Edit > Copy are refused * lane: sync web-copy memory * lane: confirm and update notes * lane: sync web-copy memory * CHANGELOG: #187's web selection and paste fixes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gap 10, route 1:
desktop_selectnow works on text in web content (paragraphs, headings, links), which has no settableAXSelectedTextRange.How
peekaboo-web-text-selection.patch, last in the stack (after feat: press media, volume and brightness keys as system-defined events #80's system-defined-key).AXWebAreaand reads the element's text-marker range.AXTextMarkerForIndex, starting from the element's start index.AXNextTextMarkerForTextMarker, capped at 2048 steps and 300 ms. Past the cap, the request is refused before anything is selected.AXSelectedTextMarkerRangeon the web area, then polls the readback for up to 1 s.completedonly when the selection reads back to exactly that range.unknown(indeterminate).Docs
desktop_selectdescription and the tools.md section.Tests
swift test --filter ActionInputDriverTests: 93 passed, including the new cases:npm testpasses andnpm run checkis clean. The native build with the full patch stack passes.Live checks: pending, screen locked. Tracked in #42: