[dashboard-components] Extract dashboard metadata section helper - #373
Merged
pelikhan merged 2 commits intoAug 31, 2026
Merged
Conversation
pelikhan
marked this pull request as ready for review
August 31, 2026 21:53
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Fixed in a97e... — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderMetadataSection(...)intopages/dashboard/src/components/view-chrome.js.pages/dashboard/src/components/outcome-detail.js.pages/dashboard/PLAN.mdcomponent inventory and run log for this bounded refactor.Duplication evidence
pages/dashboard/src/components/outcome-detail.js:152as local<section><h2>...</h2>...</section>construction.pages/dashboard/src/components/view-chrome.js, making metadata sections the best remaining small presentation-only extraction for this run.Call sites collapsed
pages/dashboard/src/components/outcome-detail.jswith the sharedrenderMetadataSection(...)export frompages/dashboard/src/components/view-chrome.js.Tests added
pages/dashboard/test/unit/view-chrome.test.jsfor defaulth2metadata headings and custom heading-tag rendering.Behavior preservation evidence
pages/dashboard/test/unit/outcome-detail.test.jsassertions covering metadata headings, badges, links, and sanitized Markdown for the affected outcome detail route.Gates
cd pages/dashboard && npm install✅cd pages/dashboard && npm run build✅cd pages/dashboard && npm run typecheck✅cd pages/dashboard && npm run lint✅cd pages/dashboard && npm test✅pages/dashboard/PLAN.mdinfrastructure blockers.Blockers
Next candidates
pages/dashboard/src/presenter.js.pages/dashboard/src/presenter.js.pages/dashboard/src/presenter.js.