Avoid opening the results panel on db deletion#831
Merged
aeisenberg merged 1 commit intomainfrom Apr 19, 2021
Merged
Conversation
aeisenberg
force-pushed
the
aeisenberg/keep-panel-closed
branch
from
ff6acfd to
c5fefa3
Compare
henrymercer
approved these changes
Apr 15, 2021
Comment on lines
+177
to
+184
| // this._panel.onDidChangeViewState( | ||
| // (e) => { | ||
| // this.logger.log(JSON.stringify(e)); | ||
| // }, | ||
| // null, | ||
| // ctx.subscriptions | ||
| // ); | ||
|
|
Contributor
There was a problem hiding this comment.
Did you intend to check this in?
Contributor
Author
There was a problem hiding this comment.
Oops. No. Should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #823
Replace this with a description of the changes your pull request makes.
Checklist
@github/docs-content-codeqlhas been cc'd in all issues for UI or other user-facing changes made by this pull request.