Skip to content

Docs: Update Telemetry links#758

Merged
aeisenberg merged 3 commits intogithub:mainfrom
shati-patel:shati-patel/docs-telemetry
Mar 9, 2021
Merged

Docs: Update Telemetry links#758
aeisenberg merged 3 commits intogithub:mainfrom
shati-patel:shati-patel/docs-telemetry

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Feb 18, 2021

⚠️ Do not merge until https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code is published ⚠️ EDIT: done!

github/codeql#5211 adds the telemetry information to the main CodeQL docs site. To avoid duplication, I've removed it here and updated links.

I think I've replaced all links, but feel free to commit any changes directly!

Checklist

  • [N/A] CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • [N/A] Issues have been created for any UI or other user-facing changes made by this pull request.
  • [N/A] @github/docs-content-dsp has been cc'd in all issues for UI or other user-facing changes made by this pull request.

Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for creating this PR.

@shati-patel
Copy link
Copy Markdown
Contributor Author

⚠️ Do not merge until https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code is published ⚠️

This is now ready to merge!

@shati-patel shati-patel marked this pull request as ready for review March 9, 2021 16:35
Copy link
Copy Markdown
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aeisenberg aeisenberg enabled auto-merge (rebase) March 9, 2021 16:37
@aeisenberg
Copy link
Copy Markdown
Contributor

We also need to update TELEMETRY.md in this repo. All text should be removed and replaced by a link to https://codeql.github.com/docs/codeql-for-visual-studio-code/about-telemetry-in-codeql-for-visual-studio-code

@aeisenberg aeisenberg merged commit 1d03702 into github:main Mar 9, 2021
@shati-patel shati-patel deleted the shati-patel/docs-telemetry branch March 9, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants