Refactor: Move commandRunner to its own module#723
Merged
aeisenberg merged 1 commit intogithub:mainfrom Jan 19, 2021
Merged
Conversation
Also, extract related functions and types. There are no behavioral changes in this commit. Only refactorings.
adityasharad
approved these changes
Jan 19, 2021
Contributor
adityasharad
left a comment
adityasharad
left a comment
There was a problem hiding this comment.
LGTM. I noticed we have a mix of kebab-case and camelCase in module filenames (usually the former). We can consider making that consistent, but I currently don't feel strongly about it.
Contributor
Author
|
I'm guilty of using camel case for module names (which I slightly prefer). It would be good to standardize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, extract related functions and types. There are no behavioral changes in this commit. Only refactorings.
This aligns with the same refactoring in #611.