Remove extension telemetry setting and use VS Code setting instead#3853
Merged
Remove extension telemetry setting and use VS Code setting instead#3853
Conversation
robertbrignull
approved these changes
Dec 5, 2024
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
Code LGTM and I tried it out and the popup worked as expected (one non-blocking comment)
| let chosenItem; | ||
|
|
||
| do { | ||
| chosenItem = await window.showInformationMessage( |
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Yes, I agree that this is quite annoying, but I also couldn't find a way to hide it. An alternative solution would be to keep the old setting for a few releases while showing this dialog, where the cancel button would simply keep using the old setting. However, we hope this scenario is quite rare and don't think it's worth the effort to have a "transition" like that which would require some additional work in a few releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This removes the
codeQL.telemetry.enableTelemetrysetting and uses the VS Code settings instead. This is done automatically in thevscode-extension-telemetrypackage, so we don't need to check the VS Code settings.Since this changes the telemetry when you currently have the extension telemetry disabled, but the VS Code telemetry enabled, this also adds a non-dismissable notification when starting the extension (if VS Code telemetry is enabled and
codeQL.telemetry.enableTelemetryisfalse).The E2E tests are expected to fail since it installs the released extension rather than the extension from the repo.