Send telemetry for addDatabaseSourceToWorkspace setting#3238
Merged
shati-patel merged 4 commits intomainfrom Jan 16, 2024
Merged
Send telemetry for addDatabaseSourceToWorkspace setting#3238shati-patel merged 4 commits intomainfrom
addDatabaseSourceToWorkspace setting#3238shati-patel merged 4 commits intomainfrom
Conversation
shati-patel
force-pushed
the
shati-patel/telemetry-test
branch
from
ffe3c77 to
7a0184d
Compare
koesie10
approved these changes
Jan 16, 2024
| "config", | ||
| { | ||
| ...config, | ||
| cliVersion: this.cliVersionStr, |
Member
There was a problem hiding this comment.
Would it also be useful to have the isCanary setting available here to check whether a certain setting is only used by canary users?
Contributor
There was a problem hiding this comment.
Makes sense to me too. We may as well include isCanary here in all the config information events.
robertbrignull
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd like to know if users are re-enabling the old behaviour of auto-adding database sources to the workspace. In future, this same approach could be extended to other settings.
See internal linked issue for more info and an example Kusto query! 🔗
Checklist
ready-for-doc-reviewlabel there.