Skip to content

Remove GitHub database download feature flag #3138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 2 commits into from
Dec 14, 2023
Merged

Remove GitHub database download feature flag #3138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf50a71
Remove GitHub database download feature flag
koesie10 Dec 14, 2023
4bd1981
Update CHANGELOG
koesie10 Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [UNRELEASED]

- Add a prompt for downloading a GitHub database when opening a GitHub repository. [#3138](https://github.com/github/vscode-codeql/pull/3138)
- Avoid showing a popup when hovering over source elements in database source files. [#3125](https://github.com/github/vscode-codeql/pull/3125)

## 1.11.0 - 13 December 2023
Expand Down
7 changes: 0 additions & 7 deletions extensions/ql-vscode/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,8 +762,6 @@ export class ModelConfigListener extends ConfigListener implements ModelConfig {

const GITHUB_DATABASE_SETTING = new Setting("githubDatabase", ROOT_SETTING);

// Feature flag for the GitHub database downnload.
const GITHUB_DATABASE_ENABLE = new Setting("enable", GITHUB_DATABASE_SETTING);
const GITHUB_DATABASE_DOWNLOAD = new Setting(
"download",
GITHUB_DATABASE_SETTING,
Expand All @@ -778,7 +776,6 @@ const GitHubDatabaseUpdateValues = ["ask", "never"] as const;
type GitHubDatabaseUpdate = (typeof GitHubDatabaseUpdateValues)[number];

export interface GitHubDatabaseConfig {
enable: boolean;
download: GitHubDatabaseDownload;
update: GitHubDatabaseUpdate;
setDownload(
Expand All @@ -802,10 +799,6 @@ export class GitHubDatabaseConfigListener
);
}

public get enable() {
return !!GITHUB_DATABASE_ENABLE.getValue<boolean>();
}

public get download(): GitHubDatabaseDownload {
const value = GITHUB_DATABASE_DOWNLOAD.getValue<GitHubDatabaseDownload>();
return GitHubDatabaseDownloadValues.includes(value) ? value : "ask";
Expand Down
4 changes: 0 additions & 4 deletions extensions/ql-vscode/src/databases/github-databases/github-databases-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ export class GitHubDatabasesModule extends DisposableObject {
}

private async initialize(): Promise<void> {
if (!this.config.enable) {
return;
}

// Start the check and downloading the database asynchronously. We don't want to block on this
// in extension activation since this makes network requests and waits for user input.
void this.promptGitHubRepositoryDownload().catch((e: unknown) => {
Expand Down