Skip to content

Upgrade MSW #2877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koesie10 merged 19 commits into from
Oct 3, 2023
Merged

Upgrade MSW #2877

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e719df7
Upgrade msw to the @next tag
robertbrignull Sep 19, 2023
7c1b6e2
Use new types
robertbrignull Sep 19, 2023
e34f4ed
Only start server when loading a scenario
robertbrignull Sep 19, 2023
ffc90a0
Remove startServer method as it now does nothing
robertbrignull Sep 19, 2023
a1ea1f8
Upgrade Octokit and MSW
koesie10 Sep 28, 2023
3c10e87
Switch Octokit to use `node-fetch`
koesie10 Sep 28, 2023
9b10a09
Fix MSW JSON responses
koesie10 Sep 28, 2023
f227147
Use AppOctokit in tests
koesie10 Sep 28, 2023
3afa15a
Remove redundant query params
koesie10 Sep 28, 2023
f9ddb40
Switch to stable VS Code version for tests
koesie10 Sep 28, 2023
8b1c528
Fix typing error for Octokit
koesie10 Sep 28, 2023
ae2d6ce
Upgrade Node version to 18.15.0
koesie10 Sep 28, 2023
40b79f2
Improve scenario recording
koesie10 Sep 29, 2023
7578697
Fix response bodies when recording
koesie10 Oct 2, 2023
095d56e
Fix typo in BasicErrorResponse
koesie10 Oct 2, 2023
6539417
Fix recording of binary response bodies
koesie10 Oct 2, 2023
e15b768
Bump @types/vscode to 1.82.0
koesie10 Oct 2, 2023
8107bf7
Merge remote-tracking branch 'origin/main' into robertbrignull/upgrad…
koesie10 Oct 3, 2023
83e38c8
Update CHANGELOG
koesie10 Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cli-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down Expand Up @@ -110,7 +110,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down Expand Up @@ -149,7 +149,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down Expand Up @@ -251,7 +251,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'
cache: 'npm'
cache-dependency-path: extensions/ql-vscode/package-lock.json

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: '16.17.1'
node-version: '18.15.0'

- name: Install dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions docs/node-version.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ The following files will need to be updated:
- `extensions/ql-vscode/.nvmrc` - this will enable nvm to automatically switch to the correct node version when you're in the project folder
- `extensions/ql-vscode/package-lock.json` - the "engines.node: '[VERSION]'" setting
- `extensions/ql-vscode/package.json` - the "engines.node: '[VERSION]'" setting
- `extensions/ql-vscode/package.json` - the "@types/node: '[VERSION]'" dependency

## Node.js version used in tests

Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/.nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.17.1
v18.15.0
1 change: 1 addition & 0 deletions extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [UNRELEASED]

- Increase the required version of VS Code to 1.82.0. [#2877](https://github.com/github/vscode-codeql/pull/2877)
- Fix a bug where the query server was restarted twice after configuration changes. [#2884](https://github.com/github/vscode-codeql/pull/2884).

## 1.9.1 - 29 September 2023
Expand Down
Loading