Skip to content

Remove conditionals and version constraints for unsupported CLI versions#2627

Merged
charisk merged 4 commits intomainfrom
charisk/remove-deprecated-version-support
Jul 24, 2023
Merged

Remove conditionals and version constraints for unsupported CLI versions#2627
charisk merged 4 commits intomainfrom
charisk/remove-deprecated-version-support

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jul 21, 2023

We dropped support for CLI versions older than 2.9.4 in #2610.

This PR removes conditionals and version constraints for unsupported CLI versions.

See individual commits for more details.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner July 21, 2023 15:39
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we can also remove the CLI_VERSION_WITH_PER_QUERY_EVAL_LOG constraint (2.9.0), but the other changes look good to me.

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Jul 24, 2023

I believe that we can also remove the CLI_VERSION_WITH_PER_QUERY_EVAL_LOG constraint (2.9.0), but the other changes look good to me.

Good shout, I missed that one. Done now.

Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit 8314a54 into main Jul 24, 2023
@charisk charisk deleted the charisk/remove-deprecated-version-support branch July 24, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants