Remove conditionals and version constraints for unsupported CLI versions#2627
Merged
Remove conditionals and version constraints for unsupported CLI versions#2627
Conversation
koesie10
reviewed
Jul 24, 2023
Member
koesie10
left a comment
There was a problem hiding this comment.
I believe that we can also remove the CLI_VERSION_WITH_PER_QUERY_EVAL_LOG constraint (2.9.0), but the other changes look good to me.
Contributor
Author
Good shout, I missed that one. Done now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We dropped support for CLI versions older than 2.9.4 in #2610.
This PR removes conditionals and version constraints for unsupported CLI versions.
See individual commits for more details.
Checklist
N/A:
ready-for-doc-reviewlabel there.