Skip to content

Update selected code flow when data flow paths change #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charisk merged 2 commits into from
Apr 11, 2023
Merged

Update selected code flow when data flow paths change #2288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f0cc2
Update selected code flow when data flow paths change
charisk Apr 6, 2023
eb6496a
Update CHANGELOG
charisk Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extensions/ql-vscode/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [UNRELEASED]

- Fix bug that was causing code flows to not get updated when switching between results. [#2288](https://github.com/github/vscode-codeql/pull/2288)
- Restart the CodeQL language server whenever the _CodeQL: Restart Query Server_ command is invoked. This avoids bugs where the CLI version changes to support new language features, but the language server is not updated. [#2238](https://github.com/github/vscode-codeql/pull/2238)

## 1.8.1 - 23 March 2023
Expand Down
5 changes: 5 additions & 0 deletions extensions/ql-vscode/src/view/data-flow-paths/DataFlowPaths.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@ export const DataFlowPaths = ({

const { codeFlows, ruleDescription, message, severity } = dataFlowPaths;

React.useEffect(() => {
// Make sure to update the selected code flow if the data flow paths change
setSelectedCodeFlow(dataFlowPaths.codeFlows[0]);
}, [dataFlowPaths]);

return (
<>
<VerticalSpace size={2} />
Expand Down