Deprecate download from LGTM by hiding it behind canary flag#1467
Merged
Deprecate download from LGTM by hiding it behind canary flag#1467
Conversation
charisk
reviewed
Aug 23, 2022
Contributor
|
PR looks good but a note we don't want to merge this just yet. Need to get a few other things done first. |
Contributor
|
Should be good to merge now. We have the documentation and changelog post ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hide the download from LGTM functionality behind the canary config setting, effectively removing it for all normal users.
Checklist
ready-for-doc-reviewlabel there.