Skip to content

Remove canary requirement for GitHub database download#1466

Merged
koesie10 merged 2 commits intomainfrom
koesie10/add-github-download-button
Aug 23, 2022
Merged

Remove canary requirement for GitHub database download#1466
koesie10 merged 2 commits intomainfrom
koesie10/add-github-download-button

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Aug 23, 2022

This adds the ability for users to download CodeQL databases from GitHub without the canary flag being set. Since this feature requires GitHub authentication, the "Authenticate to GitHub" command is now also available.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 requested a review from a team August 23, 2022 12:55
@koesie10 koesie10 requested a review from a team as a code owner August 23, 2022 12:55
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

@koesie10 koesie10 requested a review from charisk August 23, 2022 14:13
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@koesie10 koesie10 merged commit edcac69 into main Aug 23, 2022
@koesie10 koesie10 deleted the koesie10/add-github-download-button branch August 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants