Skip to content

"Open Query Results" button causes error: "Cannot read property 'result' of undefined" #906

@Marcono1234

Description

@Marcono1234

Describe the bug
When using the "Open Query Results" button of the Query History view an error occurs.
Button:
Query History screenshot

Log:

Cannot read property 'result' of undefined (codeQLQueryHistory.itemClicked)
TypeError: Cannot read property 'result' of undefined
	at InterfaceManager.showResults (#REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\interface.js:227:21)
	at showResultsForCompletedQuery (#REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\extension.js:311:20)
	at showResults (#REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\extension.js:291:41)
	at QueryHistoryManager.invokeCallbackOn (#REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\query-history.js:207:19)
	at QueryHistoryManager.handleItemClicked (#REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\query-history.js:318:24)
	at #REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\query-history.js:189:25
	at #REDACTED#\.vscode\extensions\github.vscode-codeql-1.5.1\out\commandRunner.js:61:26
	...

Note that clicking on one of the history entries opens the query results just fine.

Though to be honest, I am not sure if the "Open Query Results" button adds any value in the first place, since you would most likely first have to select the entry from the history (by left clicking?), but by doing so you already opened the query results.

Version
CodeQL extension:

CodeQL extension version: 1.5.1 
CodeQL CLI version: 2.5.7 
Platform: win32 x64

VSCode:

Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041

To reproduce

  1. Load any Java database
  2. Run the following Quick Query
    import java
    
    select ""
  3. Click the "Open Query Results" button of the Query History on the left
    ❌ An error occurs

Metadata

Metadata

Assignees

Labels

VSCodebugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions