Skip to content

Add rationale and confidence to closing an issue - #2802

Merged
kerobbi merged 5 commits into
mainfrom
iunia/issues-granular-update-state
Jul 6, 2026
Merged

Add rationale and confidence to closing an issue#2802
kerobbi merged 5 commits into
mainfrom
iunia/issues-granular-update-state

Conversation

@iulia-b

@iulia-b iulia-b commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Similar to fields and type, this PR adds the ability of suggesting a "close issue" intent, with confidence, rationale, and support for duplicate issue .

Why

Fixes https://github.com/github/plan-track-agentic-toolkit/issues/343

What changed

  • Rewrote the granular update_issue_state tool as a standalone function (off the issueUpdateTool helper)
  • added four new optional params: rationale, confidence, is_suggestion, and duplicate_of
  • When intent params are provided, the tool sends the state as an object {"state": {"value": "closed", ...}} to the REST API instead of a plain string
  • duplicate_of accepts an issue number and resolves it to a DB id before sending duplicate_issue_id in the request body.
  • Suggestion closes as duplicate require duplicate_of. Direct closes do not.

MCP impact

  • No tool or API changes
  • Tool schema or behavior changed
  • New tool added

Prompts tested (tool changes only)

Security / limits

  • No security or limits impact
  • Auth / permissions considered
  • Data exposure, filtering, or token/size limits considered

Tool renaming

  • I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
    • I have added the new tool aliases in deprecated_tool_aliases.go
  • I am not renaming tools as part of this PR

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

  • Linted locally with ./script/lint
  • Tested locally with ./script/test

Docs

  • Not needed
  • Updated (README / docs / examples)

@iulia-b
iulia-b requested a review from Copilot July 2, 2026 10:34
Copilot AI reviewed Jul 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the granular update_issue_state tool to support “close issue” intent metadata (rationale, confidence, and suggestion semantics) and adds support for closing as a duplicate by resolving an issue number to a database ID for duplicate_issue_id.

Changes:

  • Reworks update_issue_state into a standalone tool handler so it can send either the standard REST body or an object-form state payload with intent metadata.
  • Adds new optional parameters: rationale, confidence, is_suggestion, and duplicate_of (with lookup to duplicate_issue_id).
  • Updates tests, tool schema snapshot, and feature-flag documentation for the new parameters.
Show a summary per file
File Description
pkg/github/issues_granular.go Implements object-form state update payload (intent metadata) and duplicate resolution flow for update_issue_state.
pkg/github/granular_tools_test.go Adds coverage for suggestion mode, duplicate handling, and validation errors for the updated tool behavior.
pkg/github/toolsnaps/update_issue_state.snap Updates the tool snapshot to reflect new schema fields and updated description.
docs/feature-flags.md Documents the new update_issue_state parameters for feature-flagged granular issues tools.

Review details

  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Low

Comment thread pkg/github/issues_granular.go
Comment thread docs/feature-flags.md Outdated
iulia-b and others added 2 commits July 6, 2026 10:20
@iulia-b
Potential fix for pull request finding
7c2b4f9 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@iulia-b
Merge branch 'main' into iunia/issues-granular-update-state
8d0fd73
@iulia-b

iulia-b commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Closing as a dupe of, after fixing rest to accept duplicate_issue_id

image

Suggesting to close as a dupe:

image image

@iulia-b
iulia-b requested a review from Copilot July 6, 2026 08:38
@iulia-b iulia-b self-assigned this Jul 6, 2026
@iulia-b
iulia-b marked this pull request as ready for review July 6, 2026 08:38
@iulia-b
iulia-b requested a review from a team as a code owner July 6, 2026 08:38
Copilot AI reviewed Jul 6, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 4/4 changed files
  • Comments generated: 3
  • Review effort level: Low

Comment thread pkg/github/issues_granular.go
Comment thread pkg/github/issues_granular.go
Comment thread docs/feature-flags.md
@kerobbi
kerobbi merged commit 74c34cd into main Jul 6, 2026
19 checks passed
@kerobbi
kerobbi deleted the iunia/issues-granular-update-state branch July 6, 2026 18:24
@BrewTestBot BrewTestBot mentioned this pull request Jul 15, 2026
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Aug 18, 2026
Merged
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
HarmonybrewBot HarmonybrewBot
!14323 merge bump-github-mcp-server-1.6.0 into main
fcb751d 
github-mcp-server 1.6.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## Highlights ⭐️
* **Tool response filtering**: We added a new `fields` parameter to selected tools in Insiders mode, allowing models to specify which fields they need when they call those tools, thus shrinking tool response size and optimizing context usage. Try it out and let us know if you have any feedback!

## What's Changed
* chore(deps): upgrade go-sdk to v1.7.0-pre.1 (new MCP spec) by @SamMorrowDrums in github/github-mcp-server#2787
* build(deps): bump SamMorrowDrums/mcp-server-diff from 3521651bb0d3cc267a23df8d94a2a645556980a4 to 40d992e0a220e5b63378758f9a40d6a8982898d2 by @dependabot[bot] in github/github-mcp-server#2795
* build(deps): bump golang.org/x/net from 0.38.0 to 0.55.0 in the go_modules group across 1 directory by @dependabot[bot] in github/github-mcp-server#2806
* build(deps): bump goreleaser/goreleaser-action from 7.2.2 to 7.2.3 by @dependabot[bot] in github/github-mcp-server#2796
* Add is_suggestion + rationale to update_issue_assignees by @kelsey-myers in github/github-mcp-server#2821
* Add rationale and confidence to closing an issue by @iulia-b in github/github-mcp-server#2802
* Sanitize and lockdown-gate issue_read get_parent title by @zwick in github/github-mcp-server#2780
* Enrich issue_read get with hierarchy relationship signals by @zwick in github/github-mcp-server#2764
* build(deps): bump docker/build-push-action from 7.2.0 to 7.3.0 by @dependabot[bot] in github/github-mcp-server#2828
* chore(deps): bump go-github v87 → v89 and resolve breaking changes by @tommaso-moro in github/github-mcp-server#2840
* Reimplement issue dependencies on go-github v89 REST API by @tommaso-moro in github/github-mcp-server#2839
* Add README links for community resources by @insonmia0126-lovable in github/github-mcp-server#2848
* Add fields param to search_code and get_file_contents by @tommaso-moro in github/github-mcp-server#2775
* Add fields param to six more list/search tools by @tommaso-moro in github/github-mcp-server#2810
* MCP: name-based resolution for Projects fields by @veralizeth in github/github-mcp-server#2760
* Enable fields param in Insiders mode by @tommaso-moro in github/github-mcp-server#2890

## New Contributors
* @insonmia0126-lovable made their first contribution in github/github-mcp-server#2848
* @veralizeth made their first contribution in github/github-mcp-server#2760

**Full Changelog**: https://github.com/github/github-mcp-server/compare/v1.5.0...v1.6.0</pre>
  <p>View the full release notes at <a href="https://github.com/github/github-mcp-server/releases/tag/v1.6.0">https://github.com/github/github-mcp-server/releases/tag/v1.6.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!14323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@kerobbi kerobbi kerobbi approved these changes

Assignees

@iulia-b iulia-b

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iulia-b @kerobbi @SamMorrowDrums