fix: make failed_only a modifier for job logs#2674
Open
jstar0 wants to merge 1 commit into
Open
Conversation
Guccitalo
referenced
this pull request
Jun 11, 2026
- Fix README.md: Remove non-existent 'Claude Web' from description - Add Windows PowerShell environment variable example for loading PAT from .env file The previous documentation only showed bash syntax for loading environment variables from .env files, which doesn't work on Windows PowerShell. This adds a PowerShell equivalent to help Windows users set up the GitHub MCP Server correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2389.
get_job_logscurrently treatsfailed_onlyas a mode switch, sorun_idwithfailed_only=falseerrors instead of returning the run's job logs. This makesfailed_onlya modifier for either supported identifier.Changes
run_idto return logs for all jobs, withfailed_only=truefiltering that run to failed jobs.job_id + failed_only=truecheck the job conclusion before fetching logs and return a tool error for non-failed jobs.job_id + run_idinput and missing-ID input before making GitHub API calls.Verification
I also ran
script/generate-docsto refresh the generated README tool documentation.