Remove --disable-slash-commands flag for Claude Code 1.0.0 compatibility#24807
Remove --disable-slash-commands flag for Claude Code 1.0.0 compatibility#24807
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/00a94eec-0414-4e44-9b2b-52118e859cf4 Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready. |
|
🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation... |
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Agent Container Tool Check
Result: 12/12 tools available ✅ Overall Status: PASS
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Smoke test review: PR removes --disable-slash-commands flag from Claude Code invocations across all lock files for 1.0.0 compatibility. Changes look correct and consistent across all workflow files. LGTM.
📰 BREAKING: Report filed by Smoke Copilot · ● 1.5M
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
There was a problem hiding this comment.
Pull request overview
Updates the Claude Code engine integration to stop passing the removed --disable-slash-commands CLI flag, restoring compatibility with Claude Code 1.0.0+ and ensuring compiled workflow outputs no longer include the invalid option.
Changes:
- Remove
--disable-slash-commandsfrom the Claude CLI args builder. - Update the Claude engine unit test and golden fixture to match the new CLI invocation.
- Regenerate compiled
.lock.ymlworkflows to purge the removed flag everywhere.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/claude_engine.go | Stops injecting --disable-slash-commands into the Claude CLI invocation. |
| pkg/workflow/claude_engine_test.go | Removes the assertion expecting the deprecated flag. |
| pkg/workflow/testdata/TestWasmGolden_CompileFixtures/claude-with-network.golden | Updates golden output to reflect the new Claude command line. |
| .github/workflows/test-create-pr-error-handling.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/step-name-alignment.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/static-analysis-report.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/sergo.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/semantic-function-refactor.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/scout.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/schema-consistency-checker.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/safe-output-health.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/prompt-clustering-analysis.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/lockfile-stats.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/instructions-janitor.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/hourly-ci-cleaner.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/go-pattern-detector.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/github-mcp-tools-report.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/github-mcp-structural-analysis.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/example-workflow-analyzer.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/deep-report.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-team-evolution-insights.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-security-red-team.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-safe-outputs-conformance.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-safe-output-optimizer.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-rendering-scripts-verifier.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-otel-instrumentation-advisor.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-function-namer.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-code-metrics.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/daily-choice-test.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/copilot-session-insights.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/copilot-agent-analysis.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/commit-changes-analyzer.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/cli-version-checker.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/claude-code-user-docs-review.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
| .github/workflows/audit-workflows.lock.yml | Regenerated compiled workflow; removes deprecated flag from Claude invocations. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 46/46 changed files
- Comments generated: 1
| // Add print flag for non-interactive mode | ||
| claudeArgs = append(claudeArgs, "--print") | ||
|
|
||
| // Disable slash commands for controlled execution | ||
| claudeArgs = append(claudeArgs, "--disable-slash-commands") | ||
|
|
||
| // Disable Chrome integration for security and deterministic execution | ||
| claudeArgs = append(claudeArgs, "--no-chrome") |
There was a problem hiding this comment.
Now that --disable-slash-commands has been removed, consider leaving a brief inline note here explaining that Claude Code v1.0.0 dropped the flag (and that passing it breaks startup). This helps prevent someone from reintroducing the arg later when scanning for “hardening” flags.
Smoke Test Results — Run 24016762959
Overall: PARTIAL — 17 passed, 2 skipped, 0 failed
|
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude · ● 301K
| @@ -847,7 +847,7 @@ jobs: | |||
| touch /tmp/gh-aw/agent-step-summary.md | |||
| # shellcheck disable=SC1003 | |||
There was a problem hiding this comment.
✅ Smoke test review: Correctly removes --disable-slash-commands flag — this flag was removed in Claude Code 1.0.0 and is no longer valid. Good change for compatibility.
| @@ -740,7 +740,7 @@ jobs: | |||
| touch /tmp/gh-aw/agent-step-summary.md | |||
| # shellcheck disable=SC1003 | |||
There was a problem hiding this comment.
✅ Smoke test review: Same --disable-slash-commands removal here. Consistent change across all lock files. LGTM!
|
@copilot apply changes based on the comments in this thread |
Claude Code 1.0.0 dropped
--disable-slash-commandsas a breaking change. The compiler unconditionally injected it, causing all Claude-engine workflows to fail at startup witherror: unknown option '--disable-slash-commands'.Changes
pkg/workflow/claude_engine.go— Remove--disable-slash-commandsfrom the Claude CLI args builderpkg/workflow/claude_engine_test.go— Remove assertion for the now-absent flagclaude-with-network.golden— Update golden output accordingly.lock.ymlfiles — Recompiled viamake recompileto purge the flag from all compiled workflowsWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw -embedcfg /tmp/go-build3606987751/b063/embedcfg -pack(http block)/usr/bin/gh /usr/bin/gh api graphql -f query=query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { hasDiscussionsEnabled } } -f owner=github -f name=gh-aw _value"]."\n";(http block)https://api.github.com/repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b/usr/bin/gh gh api /repos/astral-sh/setup-uv/git/ref/tags/eac588ad8def6316056a12d4907a9d4d84ff7a3b --jq .object.sha(http block)https://api.github.com/repos/github/gh-aw/usr/bin/gh gh api /repos/github/gh-aw --jq .visibility(http block)https://api.github.com/repos/githubnext/agentics/git/ref/tags/-/usr/bin/gh gh api /repos/githubnext/agentics/git/ref/tags/- --jq .object.sha(http block)If you need me to access, download, or install something from one of these locations, you can either:
✨ PR Review Safe Output Test - Run 24016762959