C++: Make classes in models.implementations private#4634
Merged
rdmarsh2 merged 18 commits intogithub:mainfrom Nov 24, 2020
Merged
C++: Make classes in models.implementations private#4634rdmarsh2 merged 18 commits intogithub:mainfrom
rdmarsh2 merged 18 commits intogithub:mainfrom
Conversation
…tside the library).
…tion proper interfaces.
rdmarsh2
reviewed
Nov 6, 2020
Contributor
|
Looks like the autoformat check is only reporting one file at a time. I'll take a look at fixing it. |
Contributor
Author
|
I think I've now autoformatted all the files. |
Contributor
|
Looks like |
1 task
Contributor
Author
Hmm, maybe I need to update my autoformatter... |
Contributor
|
Yes, I think so. It looks like the version you're using is undoing part of #4641 |
Contributor
Author
|
Fixed autoformat and merge conflict. |
rdmarsh2
previously approved these changes
Nov 20, 2020
…tSafeExternalAPIFunction implementation.
Contributor
Author
|
Pushed an update to keep up with |
geoffw0
commented
Nov 23, 2020
Contributor
Author
|
Duplication tests are failing now (sigh). I think this has been fixed in main, so I've just updated to latest and am crossing my fingers. |
rdmarsh2
reviewed
Nov 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make classes in
models.implementationsthat are not referenced elsewhere private.I've also added interfaces for four classes so that the implementations can become private:
OperatorNewAllocationFunction,OperatorDeleteDeallocationFunction,IteratorandSnprintf. I'm very open to hear people's opinions on the design of these, whether having the odd thing inimplementationsbe public is OK or intolerable, etc.I plan to make a couple of follow-up PRs with some further cleanup, and addressing more non-private classes in
FormattingFunction- but I don't want to overcomplicate what is here.