CodeQL training: update QL4E links and provide database instructions - #2461
Merged
Merged
Conversation
jf205
changed the title
jf205
commented
Nov 27, 2019
| margin-bottom: 0; | ||
| } | ||
|
|
||
| .admonition.note ol { |
Contributor
Author
There was a problem hiding this comment.
This CSS tweak is required to make numbered lists look sensible on the notes pages.
shati-patel
approved these changes
Nov 27, 2019
shati-patel
left a comment
shati-patel
left a comment
Contributor
There was a problem hiding this comment.
LGTM - I'll let @lcartey check and merge.
Contributor
Author
|
@lcartey, do you think this is the correct approach for VS Code users? |
Contributor
Author
|
@lcartey, I'd like to get this merged today, if you have a moment to review it please? |
lcartey
approved these changes
Dec 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses https://github.com/github/pe-security-codeql/issues/172
Specifically, links to QL for Eclipse have been updated to CodeQL for VS Code and very brief instructions about unzipping/upgrading databases have been added.
For example, see the notes here: http://docteam.internal.semmle.com/james/ql-training/172/cpp/bad-overflow-guard.html#2