JS: support additional Flow syntax: ... in object types - #2444
Merged
Conversation
max-schaefer
approved these changes
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flow now(?) allows
type D = { d: D, ... }, optionally with a trailing comma or semicolon after the three dots. We previously expected type to follow the three dots.The amount of FP fixes we get for this merits a hotfix for the 1.23 release: https://git.semmle.com/esben/dist-compare-reports/tree/js/flow-spread-prop-types_1574775153102.
The two first new syntax errors were presumably previously hidden by the FP syntax errors.
The latter new syntax error is simply due to the trailing semicolon, the latest version of this PR now supports the trailing semicolon as well.