Skip to content

C#: Remove the query cs/useless-assignment-to-local from the code-quality suite.#22193

Open
michaelnebel wants to merge 3 commits into
github:mainfrom
michaelnebel:csharp/diableuselessassignment
Open

C#: Remove the query cs/useless-assignment-to-local from the code-quality suite.#22193
michaelnebel wants to merge 3 commits into
github:mainfrom
michaelnebel:csharp/diableuselessassignment

Conversation

@michaelnebel

@michaelnebel michaelnebel commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

In this PR we remove the query cs/useless-assignment-to-local from the code-quality suite.

@michaelnebel michaelnebel force-pushed the csharp/diableuselessassignment branch from 20c3ea4 to cb3f8a8 Compare July 15, 2026 07:16
@michaelnebel michaelnebel changed the title C#: Set the precision of cs/useless-assignment-to-local to medium. C#: Remove the query cs/useless-assignment-to-local from the code-quality suite. Jul 15, 2026
@michaelnebel michaelnebel marked this pull request as ready for review July 15, 2026 07:53
@michaelnebel michaelnebel requested a review from a team as a code owner July 15, 2026 07:53
Copilot AI review requested due to automatic review settings July 15, 2026 07:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes cs/useless-assignment-to-local from C#’s standard code-quality suite while retaining it in the extended suite.

Changes:

  • Excludes the query from the standard suite.
  • Updates integration-test expectations and release notes.
Show a summary per file
File Description
csharp/ql/src/codeql-suites/csharp-code-quality.qls Excludes the query by ID.
csharp/ql/src/change-notes/2026-07-15-code-quality-useless-assignment.md Documents the suite change.
csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected Updates expected suite contents.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants