C++: Fix interface for GuardCondition.comparesEq and GuardCondition.ensuresEq - #15976
Merged
Conversation
jketema
approved these changes
Mar 19, 2024
Contributor
Author
|
DCA looks uneventful 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the interface slightly wrong in #15958: In
codeql/cpp/ql/lib/semmle/code/cpp/controlflow/IRGuards.qll
Line 143 in 219cd4e
switch. So instead, this PR updates the newly added predicates to instead have anAbstractValuecolumn. The effect of this is visible in the second commit where we previously had:which made no sense.
Note that this isn't a breaking change since the new predicates has only been there for about ... 30 minutes 😂