JS: Add DataFlow::Node.getLocation#15882
Merged
hvitved merged 2 commits intogithub:mainfrom Mar 19, 2024
Merged
Conversation
hvitved
force-pushed
the
js/dataflow-node-get-location
branch
from
7656b93 to
1d0e5d1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| string getContents() { result = this.getText() } | ||
|
|
||
| /** Gets this element's location. */ | ||
| Location getLocation() { result = super.getLocation() } |
Check warning
Code scanning / CodeQL
Missing override annotation
hvitved
force-pushed
the
js/dataflow-node-get-location
branch
5 times, most recently
from
5a0db29 to
1b249e9
Compare
hvitved
force-pushed
the
js/dataflow-node-get-location
branch
from
1b249e9 to
16cef92
Compare
asgerf
reviewed
Mar 13, 2024
asgerf
approved these changes
Mar 18, 2024
Contributor
asgerf
left a comment
asgerf
left a comment
There was a problem hiding this comment.
Thanks for taking care of this! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #15853.
The increase in extraction errors reported by DCA is because some
@json_parse_errorentities apparently have locations inhasLocationand notjson_locations.