This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Ensure FunctionInputs corresponding to results have an entry node#348
Merged
max-schaefer merged 3 commits intogithub:mainfrom Sep 23, 2020
Merged
Ensure FunctionInputs corresponding to results have an entry node#348max-schaefer merged 3 commits intogithub:mainfrom
FunctionInputs corresponding to results have an entry node#348max-schaefer merged 3 commits intogithub:mainfrom
Conversation
Contributor
Author
|
Initial evaluation on https://github.com/cockroachdb/cockroach looks promising, but I'm running a full comparison to be on the safe side. |
Contributor
|
Checking my understanding of the generalisation: we stop caring at all about PostUpdateNodes here because this isn't really updating anything, it's an output that so happens to behave quite similarly to post/pre-update node association when dealing with SSA def-use chains, but not in the direct use case? |
Contributor
Author
|
Yes, I think that's a fair summary. |
smowton
approved these changes
Sep 22, 2020
Contributor
smowton
left a comment
There was a problem hiding this comment.
Righto, in that case I approve this message.
Contributor
Author
|
Evaluation came back fine. |
Contributor
|
It worked. I was able to remove my work around and get the correct results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the entry node is required to be a post-update SSA node, so we get an entry node for the result of
NewEncoderin this snippet:But not in this one:
This is unfortunate, since in this case it prevents us from stitching together the models for
Encode(first argument -> receiver) andNewEncoder(result -> first argument).This PR proposes to fix this by taking the entry node to be the result itself if it isn't assigned to an SSA variable. (We still do want it to be the SSA variable if there is one, since otherwise we'd lose flow in the first example.)
It feels like there should be a more principled solution, but for now I think this fixes our immediate problem.
For ease of reviewing, I have structured this PR into three commits: