Skip to content

Improve pr-checks.yml triggers and conditions #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve pr-checks.yml triggers and conditions #4219

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba79a4f
Do not run `pr-checks` for all push events
mbg Oct 9, 2026
2883b5b
Fix conditions in `pr-checks` workflow
mbg Oct 9, 2026
a6ff2ad
Use `github.actor` for `post-repo-size-comment` condition
mbg Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: PR Checks

on:
push:
branches:
- "main"
- "releases/v*"
Comment on lines +5 to +7

@henrymercer henrymercer Oct 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this trigger on all pushes is useful for catching problems where folks edit a TS file and push it to a branch to do some testing, but forget to compile the Action. This failing check is then be a useful indicator to help resolve why their intended behaviour wasn't occurring.

@mbg mbg Oct 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a very niche use case that comes at the cost of a lot of extra runs and confusion. For testing, I'd suggest opening a draft PR that triggers the checks instead of relying on push triggers.

If you feel strongly that this is a useful behaviour though, then I'd suggest we split out the relevant checks from this workflow (possibly as a reusable workflow) that is called by a workflow with a different name that runs on push and this one.

pull_request:
merge_group:
types: [checks_requested]
Expand Down Expand Up @@ -145,12 +148,11 @@ jobs:

- name: Fetch base commit
id: fetch-base
# Forks and Dependabot PRs don't have permission to write comments, so skip the repo size
# check in those cases.
# Skip this (and subsequent steps) if the PR originates from a fork, since this workflow
# won't have the necessary permissions to post comments on the PR.
if: >-
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.user.login != 'dependabot[bot]'
github.event.pull_request.head.repo.full_name == github.repository
env:
BASE_SHA: ${{ github.event.pull_request.base.sha }}
HEAD_SHA: ${{ github.event.pull_request.head.sha }}
Expand Down Expand Up @@ -209,7 +211,7 @@ jobs:
if: >-
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name == github.repository &&
github.event.pull_request.user.login != 'dependabot[bot]' &&
github.actor != 'dependabot[bot]' &&
needs.other-checks.result == 'success'
permissions:
contents: read
Expand Down
Loading